Fix/cd snupkg glob#107
Open
kieronlanning wants to merge 2 commits into
Open
Conversation
- dotnet pack without SymbolPackageFormat=snupkg produces .symbols.nupkg, not .snupkg - Use nullglob so the release create doesn't fail if a glob matches nothing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/kjldev/purview-telemetry-sourcegenerator/sessions/7aa7cf82-b45e-4619-92d2-1a55a51d5779 Co-authored-by: kieronlanning <5364423+kieronlanning@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the CD release asset upload more robust by safely collecting NuGet package artifacts before calling gh release create, and adds local act workflow-testing scaffolding.
Changes:
- Uses
nullgloband arrays to avoid passing unmatched.nupkg/.snupkgglobs togh release create. - Fails release creation when no
.nupkgassets are found and warns when symbols are missing. - Adds local
actconfig plus ignored secret/env files and a secrets template.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/cd.yml |
Safely collects NuGet release assets before creating the GitHub Release. |
.actrc |
Adds default act options for local workflow execution. |
.secrets.template |
Provides a template for local act secrets. |
.gitignore |
Ignores local act secret and environment files. |
Comment on lines
+146
to
+157
| shopt -s nullglob | ||
| PACKAGES=( ./artifacts/nuget/*.nupkg ) | ||
| SYMBOLS=( ./artifacts/nuget/*.snupkg ) | ||
| shopt -u nullglob | ||
|
|
||
| if (( ${#PACKAGES[@]} == 0 )); then | ||
| echo "::error::No .nupkg package assets found in ./artifacts/nuget." | ||
| exit 1 | ||
| fi | ||
|
|
||
| if (( ${#SYMBOLS[@]} == 0 )); then | ||
| echo "::warning::No .snupkg symbol assets found in ./artifacts/nuget." |
Comment on lines
+9
to
+11
|
|
||
| # Load env vars for act-specific overrides | ||
| --env-file .env.act |
| @@ -0,0 +1,3 @@ | |||
| # Template — copy to .secrets (gitignored) and fill in values. | |||
| # Used by act for local workflow testing. | |||
| GITHUB_TOKEN=<your-pat-with-contents:write-and-packages:write> | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.